-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unavailable_function
rule to also detect preconditionFailure()
and abort()
#3374
Closed
2 tasks done
Comments
quinntaylor
added a commit
to quinntaylor/SwiftLint
that referenced
this issue
Oct 7, 2020
PR: #3375 |
2 tasks
@jpsim / @marcelofabri, is it possible to get some eyes on this issue and PR? Thanks! |
quinntaylor
added a commit
to quinntaylor/SwiftLint
that referenced
this issue
Nov 4, 2020
jpsim
pushed a commit
to quinntaylor/SwiftLint
that referenced
this issue
Nov 7, 2020
jpsim
pushed a commit
that referenced
this issue
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New Issue Checklist
Describe the bug
The
unavailable_function
rule warns when a function containsfatalError()
with no other return branches, but does not detectpreconditionFailure()
orabort()
calls, which also terminate execution.Although Xcode fix-its often suggest
fatalError()
, some developers find it preferable to usepreconditionFailure()
instead.https://lapcatsoftware.com/articles/fatalError.html
Environment
The text was updated successfully, but these errors were encountered: