-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line length to 120 #28
Comments
This should definitely be configurable, but I personally use 100 because you can easily fit two documents side-by-side without wrapping on a reasonable laptop screen. |
Perhaps we should add the ability to configure this (issue for doing so in general: #26) and then add a standardized YAML file that we include by default? |
Personally, I'd rather see JSON. I feel like I only see YAML in the Ruby world. I feel like more iOS developer would be familiar with JSON than YAML. |
That unrelated to if the target audience is familiar with it. |
I picked the initial defaults somewhat haphazardly, and definitely appreciate issues being created to suggest more sensible defaults. Specifically, I picked 100 for line length because that's what I have my Xcode page guide set to, but I do find myself going up to 120 quite often. Ultimately, this is a question of personal preference so no matter what we pick, it'll be "wrong" for some people/projects. |
Makes sense. Definitely don't see myself leaving this on in any of my projects due to mainly this. Configuration I guess is pretty important after all. |
This is configurable now, closing. |
On a 27-inch display, you can comfortable fit two 120 wide files at 14pt with sidebars and all. On a 13" rMBP, you can fit one. I've had my guide set at 120 for years. Personally, I think 100 is overly narrow. Almost all of the warnings for one of my projects was length being over 100 but less 120.
I'm guessing there's a reason you picked 100 though. I'd love to know why!
I'm tempted to ask for a way to configure it, but I think one of the biggest benefits of this is we can all start doing things the same as a community.
The text was updated successfully, but these errors were encountered: