Comma Spacing Violation: Should not be checked in String

[arsonik]

Why would the program check if there is a space after a comma in a string ?
Example :

let reg = try! NSRegularExpression(pattern: "[a-z]{2,5}", options: NSRegularExpressionOptions.CaseInsensitive)

will fail if we add a space {2, 5}

cheers & good job by the way !

[arsonik]

Also for : Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

[bjzhou]

I have a problem like this, let url: String = "https://www.google.com" will fail, but let url = "https://www.google.com" will success

[jpsim]

@arsonik I can't reproduce your issue:

$ echo "let reg = try! NSRegularExpression(pattern: \"[a-z]{2,5}\", options: NSRegularExpressionOptions.CaseInsensitive)" | swiftlint lint --use-stdin
<nopath>:1:11: error: Force Try Violation: Force tries should be avoided. (force_try)
<nopath>:1: warning: Line Length Violation: Line should be 100 characters or less: currently 110 characters (line_length)
Done linting! Found 2 violations, 1 serious in 1 file.
$ echo "let reg = try! NSRegularExpression(pattern: \"[a-z]{2, 5}\", options: NSRegularExpressionOptions.CaseInsensitive)" | swiftlint lint --use-stdin
<nopath>:1:11: error: Force Try Violation: Force tries should be avoided. (force_try)
<nopath>:1: warning: Line Length Violation: Line should be 100 characters or less: currently 111 characters (line_length)
Done linting! Found 2 violations, 1 serious in 1 file.

@bjzhou I also can't reproduce your issue:

$ echo "let url: String = \"https://www.google.com\"" | swiftlint lint --use-stdin
Done linting! Found 0 violations, 0 serious in 1 file.
$ echo "let url = \"https://www.google.com\"" | swiftlint lint --use-stdin 
Done linting! Found 0 violations, 0 serious in 1 file.

[bjzhou]

@jpsim Don't try in command line, this issue only occurred in Xcode.

[jpsim]

SwiftLint doesn't behave differently on the command line versus Xcode.

[SokichiFujita]

@jpsim I could reproduce it. The string is for the scope string of OAuth 2.0.

[hankbao]

Same issue here.

[arsonik]

Looks like its happening only when checked in a large file&or project.

Sent from my iPhone

On 02 Dec 2015, at 1:20 PM, Hank BAO [email protected] wrote:

Same issue here.

—
Reply to this email directly or view it on GitHub.

[jpsim]

I'm still waiting for steps to reproduce this issue, as the details shared so far are insufficient to trigger it.

[bjzhou]

//
//  Created by 周斌佳 on 15/8/1.
//  Copyright © 2015年 周斌佳. All rights reserved.
//

struct Test {
    let url = "https://www.google.com"
    let url: String = "https://www.google.com"
}

@jpsim I reproduced my issue again, maybe the key is the comment. Please check it

[jpsim]

Thanks for sharing that @bjzhou, I can now reproduce the issue. I've reduced it even further:

// 周斌佳年周斌佳
let abc: String = "abc:"

Now I can investigate this.

[jpsim]

Should be fixed now. Thanks for reporting all! Next time, sharing a repro case really helps.