Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused_closure_parameter should apply to closure declarations #1082

Closed
marcelofabri opened this issue Dec 29, 2016 · 1 comment · Fixed by #3409
Closed

unused_closure_parameter should apply to closure declarations #1082

marcelofabri opened this issue Dec 29, 2016 · 1 comment · Fixed by #3409
Labels
enhancement Ideas for improvements of existing features and rules. wontfix Issues that became stale and were auto-closed by a bot.

Comments

@marcelofabri
Copy link
Collaborator

Currently, unused_closure_parameter rule is only applied for closures used in method calls. It should be applied to closure declarations as well:

let failure: Failure = { task, error in
    observer.sendFailed(error)
}
@marcelofabri marcelofabri added the enhancement Ideas for improvements of existing features and rules. label Dec 29, 2016
@marcelofabri marcelofabri mentioned this issue Jan 13, 2017
Closed
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had any recent activity. Please comment to prevent this issue from being closed. Thank you for your contributions!

@stale stale bot added the wontfix Issues that became stale and were auto-closed by a bot. label Nov 8, 2020
marcelofabri added a commit that referenced this issue Nov 8, 2020
@marcelofabri
Validate closures outside of function calls in unused_closure_parameter
45b97d1 
Fixes #1082
marcelofabri added a commit that referenced this issue Nov 8, 2020
@marcelofabri
Validate closures outside of function calls in unused_closure_parameter
7ccda8e 
Fixes #1082
@marcelofabri marcelofabri mentioned this issue Nov 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules. wontfix Issues that became stale and were auto-closed by a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate closures outside of function calls in unused_closure_parameter realm/SwiftLint
1 participant
@marcelofabri