perform Cache factory while locked

realm · Jan 2, 2017 · 8906da6 · 8906da6
1 parent 53d0cf6
commit 8906da6
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/Source/SwiftLintFramework/Extensions/File+Cache.swift b/Source/SwiftLintFramework/Extensions/File+Cache.swift
@@ -91,13 +91,12 @@ private struct Cache<T> {
     fileprivate mutating func get(_ file: File) -> T {
         let key = file.cacheKey
         lock.lock()
+        defer { lock.unlock() }
         if let cachedValue = values[key] {
-            lock.unlock()
             return cachedValue
         }
-        lock.unlock()
         let value = factory(file)
-        set(key: key, value: value)
+        values[key] = value
         return value
     }