Skip to content

Commit

Permalink
CR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mildm8nnered committed Jan 19, 2025
1 parent 2b884a6 commit 751b235
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@

### Bug Fixes

Check failure on line 151 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / Lint Markdown

Headings should be surrounded by blank lines

CHANGELOG.md:151 MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### Bug Fixes"] https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md022.md
* Add a new rationale property to rule descriptions, providing a more expansive

Check failure on line 152 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / Lint Markdown

Lists should be surrounded by blank lines

CHANGELOG.md:152 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* Add a new rationale property..."] https://github.com/DavidAnson/markdownlint/blob/v0.37.4/doc/md032.md
description of the motivation behind each rule.
description of the motivation behind each rule.
[Martin Redington](https://github.com/mildm8nnered)
[#5681](https://github.com/realm/SwiftLint/issues/5681)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct BalancedXCTestLifecycleRule: Rule {
}
```
No memory will be consumed by the value of the variable.
no memory will be consumed by the value of the variable.
More generally, if `setUp` is implemented, then `tearDown` should also be implemented, \
and cleanup performed there.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ struct BlanketDisableCommandRule: Rule, SourceKitFreeRule {
let foo = bar!
```
which disables the `force_unwrapping` rule for the remainder the file, instead of just for the specific \
which disables the `force_unwrapping` rule for the remainder of the file, instead of just for the specific \
violation.
`next`, `this`, or `previous` can be used to restrict the disable command's scope to a single line, or it \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ struct AttributesRule: Rule {
rationale: """
Erica Sadun says:
> my take on things after the poll and after talking directly with a number of \
> My take on things after the poll and after talking directly with a number of \
developers is this: Placing attributes like `@objc`, `@testable`, `@available`, `@discardableResult` on \
their own lines before a member declaration has become a conventional Swift style.
Expand Down
2 changes: 1 addition & 1 deletion Source/SwiftLintCore/Models/RuleDescription.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public struct RuleDescription: Equatable, Sendable {
rationale?.consoleRationale
}

/// The rationale for this description, with MarkDown formatting.
/// The rationale for this description, with Markdown formatting.
public var formattedRationale: String? {
rationale?.formattedRationale
}
Expand Down

0 comments on commit 751b235

Please sign in to comment.