-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
last_updated gone in footer ? #238
Comments
We had plans to link the hash to the RTD build object, or it could link back to the github commit via the hash -- maybe that would be better? It would give the closest approximation of the time the file was edited, and not just the time the file was generated on RTD. If we can give a short hash from RTD (on the roadmap, I don't think there's a ticket), I don't see much of a problem in appending the date as well. Less redundant info down there the better, I suppose. It got bumped orignally because there was too much going on at the bottom of the page. We could also use a configuration option here, though I don't know if that would be polluting our configuration option namespace or not. |
If you have the commit hash, you could have the commit date, no ? And you could have a date, which link to the commit.
Yep, I understand. I basically like to know when I land on a page if the doc build is from today, last week, last month, or last year, so that I can get an idea of wether the docs are autobuilding/maintained. I suppose you know about it, but a nice way to format date is momentjs. Thanks ! |
Are 'last updated dates' ever coming back to the stock theme? I'm not quite sure how I can add this in without making a fork of the module. Is there a simple way to get this back? |
I like the suggestion by @Carreau, it would make it a lot easier for contributors to documentation to see if their changes have taken effect, and for users to see how old the docs are. The commit hash is not useful for this at all. If the date can then be linked to the commit, this would be perfect, and eliminate the need (or longing) for a custom theme for many. |
Is there any progress on this issue at all or has is completely died out? It should not be too difficult to allow for generated documentation to simply include the dates and the commit hash (if the author would like for it to be so), or? Instead of forcing the author to choose one and only one of these to show. This could possibly be set with some simple if-statement, similar to how the sphinx_rtd_theme/sphinx_rtd_theme/footer.html Lines 17 to 23 in f237820
|
This works simply add |
@Blendify, this issue is about showing the date AND the commit hash:
|
... as suggested in readthedocs/sphinx_rtd_theme#238 (comment)
It doesn't work on https://readthedocs.org/, though, because they forcefully set the I've just created a Sphinx extension that takes the Sadly, it doesn't work on RTD because of this issue. I think it would be reasonable (as already suggested multiple times above) to show both the commit hash and the last changed date. |
Any news on this? The solution is only a click away: #897 |
Noted at #897 (comment) but the main issue that RTD will have with using So, for a design decision, I think a link to the commit is (currently) more truthy than always showing |
Noted at #897 (comment), displaying the "last updated" date is an opt-in mechanism. |
#208 seem to have made
last_updated
in footers visible only in last resort.Can it be added in addition to the revision number as revision number are nice for developers, but pretty useless for user that just want to know how old docs are ?
If so I can make a PR.
The text was updated successfully, but these errors were encountered: