-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version selector appears even with 'version_selector': False #1620
Comments
Hrm, this is due this code: sphinx_rtd_theme/sphinx_rtd_theme/static/js/versions.js_t Lines 2 to 3 in 7b894f5
which renders as:
We should update it to use a filter to make |
There was a bug with how we render a Python bool value into JavaScript. This PR fixes that issue. Closes #1620
I just released v3.0.2 that includes this fix. Please let us know if it works as expected. |
Yes issue has been fixed, thank you very much! |
Problem
The version selector appears on the top left even if there is only one version and version_selector is set to False in html_theme_options.
Reproducible Project
Project documentation: https://esieabot.readthedocs.io/en/latest/
Project documentation conf.py file: https://gitlab.esiea.fr/esieabot/esieabot-docs/rtd/-/blob/main/docs/source/conf.py
Error Logs/Results
Expected Results
It think it was expected that the version selector shouldn't be there at all?
Environment Info
The text was updated successfully, but these errors were encountered: