Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition list classifier separation missing #1190

Closed
agjohnson opened this issue Aug 9, 2021 · 1 comment · Fixed by #1192
Closed

Definition list classifier separation missing #1190

agjohnson opened this issue Aug 9, 2021 · 1 comment · Fixed by #1192
Labels
Accepted Accepted issue on our roadmap Bug A bug
Milestone

Comments

@agjohnson
Copy link
Collaborator

agjohnson commented Aug 9, 2021

This may be a regression, I remember a fix being put in place for this, but I'm not yet finding the solution. I'm noticing on Sphinx versions 2.0+ and HTML4 writer, for both the latest and stable versions of the theme. The issue is that the classifier is not separated:

image

HTML5 output works as expected.

Related to #746

@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Aug 9, 2021
@agjohnson agjohnson added this to the 1.0 milestone Aug 10, 2021
@agjohnson
Copy link
Collaborator Author

I have unearthed more information here. I did fix this, but it changed in Sphinx 2.x again. The HTML4 output for definition list classifiers matches the HTML5 output, there is no more hardcoded separator HTML element before the classifier in Sphinx 2.

agjohnson added a commit that referenced this issue Aug 12, 2021
Fix #1190: Add classifier separation on html4 writer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant