Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install latest mkdocs by default as we do with sphinx #7869

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Install latest mkdocs by default as we do with sphinx #7869

merged 2 commits into from
Mar 4, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 25, 2021

Current version is 1.1, this was pinned as we used to just keep updating them manually and time passed and this wasn't updated. This also matches my lies in #7859 :D

humitos
humitos reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can merge this yet without communicating this change to users.

readthedocs/doc_builder/python_environments.py Outdated Show resolved Hide resolved
@stsewd stsewd requested review from humitos and a team January 26, 2021 15:37
ericholscher
ericholscher approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Just to confirm, we're future_default_true'ing this on deploy?

@stsewd
Copy link
Member Author

stsewd commented Mar 4, 2021

@ericholscher yep

@stsewd stsewd merged commit cf11d24 into master Mar 4, 2021
@stsewd stsewd deleted the update-mkdocs branch March 4, 2021 23:54
@humitos
Copy link
Member

humitos commented Mar 5, 2021

Make sure that we update the Feature.created datetime at deploy time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@humitos humitos Awaiting requested review from humitos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @humitos @ericholscher