Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an advertising screen #3177

Closed

Conversation

davidfischer
Copy link
Contributor

This adds an advertiser directed page to the site where prospective advertisers can learn about advertising on RTD and ask for more information about advertising opportunities.

The advertising screen lives at /sustainability/advertising/ and when the form is submitted, the user will be redirected to /sustainability/advertising-submitted/ after an email is sent to rev@. This pull request does not update the footer to link to this page. If this is accepted, there are a number of places to update and that can come quickly in a second PR.

Some folders and files in this PR are named "advertisewithus" as opposed to "advertise" or "advertising" because some zealous ad blockers will block things named "advertise".

screenshot-2017-10-20 advertise with us read the docs

@ericholscher
Copy link
Member

This looks great to me. We can do some basic iteration on it, but happy to ship this and start sending some traffic to it :)

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine here. Again, we'll worry about organizing and reworking css later.

Any reason this was added to this repo? I thought we discussed moving things out to another repo? I'd prefer to trim down extraneous content we put into the .org codebase.

@ericholscher
Copy link
Member

This got merged in the new donate repo (private, for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants