Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two setups of the same project fail differently #7371

Closed
keewis opened this issue Aug 8, 2020 · 12 comments
Closed

two setups of the same project fail differently #7371

keewis opened this issue Aug 8, 2020 · 12 comments
Labels
Support Support question

Comments

@keewis
Copy link
Contributor

keewis commented Aug 8, 2020

I have two setups for the same project, one for the main repository and one for my fork. If the build fails because of an exception / warning, the setup for the main repository times out while the setup for my fork works as excepted (it prints the output of the failing build).

Is there anything we set on the main setup that caused this behavior?

Details

Expected Result

Both builds report the error.

Actual Result

The main setup times out instead.

@keewis
Copy link
Contributor Author

keewis commented Aug 9, 2020

also, unrelated to this issue: could you enable CONDA_APPEND_CORE_REQUIREMENTS on both setups? I'd like to have more control about which version is used.

@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

Looks like both failed because of excessive use of memory, so they failed in at a different part of the program, thus leading to different errors.

I have added the feature flag for your project.

@stsewd stsewd added Needed: more information A reply from issue author is required Support Support question labels Aug 13, 2020
@keewis
Copy link
Contributor Author

keewis commented Aug 13, 2020

thanks for setting the feature flag on both projects.

Looks like both failed because of excessive use of memory

You mean the main setup timed out because of excessive use of memory while my fork setup worked? Since I never requested a feature flag or extended memory for the fork, I think that's surprising. Is there any way to make the main setup behave more like the fork setup?

@no-response no-response bot removed the Needed: more information A reply from issue author is required label Aug 13, 2020
@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

I mean both builds failed

But one failed earlier than the other one, thus the different messages for the error.

@keewis
Copy link
Contributor Author

keewis commented Aug 13, 2020

no, the second build (https://readthedocs.org/projects/xarray-keewis/builds/11623675/) failed correctly, there was an issue with the code in the docs. However, the first build (https://readthedocs.org/projects/xray/builds/11623533/) didn't print the traceback (it timed out instead), and that's the issue here. If sphinx doesn't fail, both setups will successfully complete the builds.

@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

Ok, I don't see any constraints in your project related to build time, and both builds were running in our large builders. So one was able to finish more quickly than the other one, if you try building again you'll see one or both failing for the same reason.

Also, your original project has this feature flag

Screenshot_2020-08-13 Change feature Django site admin

@keewis
Copy link
Contributor Author

keewis commented Aug 13, 2020

thanks for investigating. We've fixed the code since I reported this, so to reproduce we'd have to rerun the same commit – not sure if that's possible. If not, I'll try to create a branch with a failing commit and push it to both repositories, and then we can try to debug a bit more.

I think the conda upgrade is not necessary anymore, we switched back to using the latest image.

Also, I noticed you enabled CONDA_APPEND_CORE_REQUIREMENTS only for my fork, could you enable it for the main project, too?

@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

We don't support running a build on a specific commit.

And looks like I set the wrong project (xarray instead of xray :D)

@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

Ok, looks like your project had some time constraints from before (xray). I have changed them to use the defaults from our new large builders. Feel free to ask to reopen if you can replicate.

@stsewd stsewd closed this as completed Aug 13, 2020
@keewis
Copy link
Contributor Author

keewis commented Aug 13, 2020

thanks, I can confirm that the version pinning of sphinx works.

I have changed them to use the defaults from our new large builders

Unfortunately it seems that didn't fix it, the main setup (xray) still times out. I added a branch (failing-docs) pointing to the failing commit to both repositories, hopefully that makes debugging easier. Trying to build them on each setup still yields different results: xray times out and xarray-keewis fails after about 6-7 minutes, printing a traceback.

@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

Looks like almos the same stack trace was produced by the two builds

AttributeError: 'DataArrayRolling' object has no attribute 'y'

Guessing sphinx terminated in a different step, so the different error. The error message you see can be different as we don't have a reliable way to detect an error produced by excessive consume of memory.

I have double check your project doesn't have any constraints.

@keewis
Copy link
Contributor Author

keewis commented Aug 16, 2020

I didn't notice the traceback, that's been my main concern. The time-out is annoying but not a serious issue, so I guess that's as far as we can get. Thanks for investigating and double checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

2 participants