Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing docs CI #4328

Closed
keewis opened this issue Aug 8, 2020 · 1 comment · Fixed by #4329
Closed

failing docs CI #4328

keewis opened this issue Aug 8, 2020 · 1 comment · Fixed by #4329

Comments

@keewis
Copy link
Collaborator

keewis commented Aug 8, 2020

The RTD builds are timing out again. With my own setup I get this error instead:

Traceback
AttributeError                            Traceback (most recent call last)
~/checkouts/readthedocs.org/user_builds/xarray-keewis/conda/latest/lib/python3.8/site-packages/IPython/core/formatters.py in __call__(self, obj)
    700                 type_pprinters=self.type_printers,
    701                 deferred_pprinters=self.deferred_printers)
--> 702             printer.pretty(obj)
    703             printer.flush()
    704             return stream.getvalue()

~/checkouts/readthedocs.org/user_builds/xarray-keewis/conda/latest/lib/python3.8/site-packages/IPython/lib/pretty.py in pretty(self, obj)
    392                         if cls is not object \
    393                                 and callable(cls.__dict__.get('__repr__')):
--> 394                             return _repr_pprint(obj, self, cycle)
    395 
    396             return _default_pprint(obj, self, cycle)

~/checkouts/readthedocs.org/user_builds/xarray-keewis/conda/latest/lib/python3.8/site-packages/IPython/lib/pretty.py in _repr_pprint(obj, p, cycle)
    698     """A pprint that just redirects to the normal repr function."""
    699     # Find newlines and replace them with p.break_()
--> 700     output = repr(obj)
    701     lines = output.splitlines()
    702     with p.group():

~/checkouts/readthedocs.org/user_builds/xarray-keewis/checkouts/latest/xarray/core/rolling.py in __repr__(self)
     99         """provide a nice str repr of our rolling object"""
    100 
--> 101         attrs = [
    102             "{k}->{v}".format(k=k, v=getattr(self, k))
    103             for k in list(self.dim) + self.window + self.center + [self.min_periods]

~/checkouts/readthedocs.org/user_builds/xarray-keewis/checkouts/latest/xarray/core/rolling.py in <listcomp>(.0)
    100 
    101         attrs = [
--> 102             "{k}->{v}".format(k=k, v=getattr(self, k))
    103             for k in list(self.dim) + self.window + self.center + [self.min_periods]
    104         ]

AttributeError: 'DataArrayRolling' object has no attribute 'y'

I think that was introduced in #4219. cc @fujiisoup

Also, we should definitely ask support why those two behave differently. Edit: see readthedocs/readthedocs.org#7371

@fujiisoup
Copy link
Member

Ah, this

attrs = [
--> 102             "{k}->{v}".format(k=k, v=getattr(self, k))
    103             for k in list(self.dim) + self.window + self.center + [self.min_periods]
    104         ]

should be "{k}->{v}".format(k=k, v=getattr(self.dims, k)) not "{k}->{v}".format(k=k, v=getattr(self, k))
I'll send a fix.

@fujiisoup fujiisoup mentioned this issue Aug 8, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants