Skip to content

Commit

Permalink
fix: unskipping a test that still works fine
Browse files Browse the repository at this point in the history
  • Loading branch information
erunion committed Oct 10, 2023
1 parent 7ca0f70 commit 8c84e1b
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/api/test/codegen/languages/typescript.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,13 @@ describe('typescript', () => {
});
});

/**
* This test is impossible to run now because its a `.js` file that's loading ESM code. The
* CJS SDK we're generating here should have a `.cjs` extension but we're going to overhaul
* this entire codegen process with `tsup` so this test is being skipped for now.
*
* @see {@link https://github.com/readmeio/api/pull/734}
*/
it.skip('should be able to make an API request (JS + CommonJS)', async () => {

Check warning on line 206 in packages/api/test/codegen/languages/typescript.test.ts

View workflow job for this annotation

GitHub Actions / linting

Disabled test
const sdk = await import('../../__fixtures__/sdk/simple-js-cjs/index.js').then(r => r.default);
fetchMock.get('http://petstore.swagger.io/v2/pet/findByStatus?status=available', mockResponse.searchParams);
Expand All @@ -208,7 +215,7 @@ describe('typescript', () => {
});
});

it.skip('should be able to make an API request (JS + ESM)', async () => {
it('should be able to make an API request (JS + ESM)', async () => {
const sdk = await import('../../__fixtures__/sdk/simple-js-esm/index.js').then(r => r.default);
fetchMock.get('http://petstore.swagger.io/v2/pet/findByStatus?status=available', mockResponse.searchParams);

Expand Down

0 comments on commit 8c84e1b

Please sign in to comment.