Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needsFixedLayoutScalerWorkAround ReaderView setting cannot be used with zoom function > 100% (clipped viewport) #177

Closed
danielweck opened this issue Apr 14, 2015 · 4 comments
Closed

needsFixedLayoutScalerWorkAround ReaderView setting cannot be used with zoom function > 100% (clipped viewport) #177

danielweck opened this issue Apr 14, 2015 · 4 comments
Assignees
@danielweck

Comments

@danielweck
Copy link
Member

Currently, only OSX uses the needsFixedLayoutScalerWorkAround workaround (to fix a WebView-specific rendering / clipping bug), see:
readium/SDKLauncher-OSX#21 (comment)

Code references:
readium/SDKLauncher-OSX@e909269#diff-14a5cfdb45121ceecfd23a430ab5652cL58

ca4e1d0#diff-7f14747656265ce3e39fee34e732d161R78

var reader = new ReadiumSDK.Views.ReaderView(
                 {
                    needsFixedLayoutScalerWorkAround: true,
                     el:"#viewport",
                     etc...
                 });
_needsFixedLayoutScalerWorkAround = options.needsFixedLayoutScalerWorkAround;
this.needsFixedLayoutScalerWorkAround = function() { return _needsFixedLayoutScalerWorkAround; }

...but, there are discussions to use the same workaround to address a Chrome rendering glitch, see:
readium/readium-js-viewer#313 (comment)
@danielweck danielweck self-assigned this Apr 14, 2015
danielweck added a commit that referenced this issue Apr 14, 2015
@danielweck
seemingly trivial fix for #177 when needsFixedLayoutScalerWorkAround …
ac77726 
…==1, scaler div dimensions need to be zoomed by the same factor, to prevent clipping when zoom > 100% (needs checking / testing with OSX, as needsFixedLayoutScalerWorkAround was introduced specifically to adress a WebView rendering glitch)
@danielweck
Copy link
Member Author

Seems fixed here:
ac77726
Needs testing with OSX WebView.

@danielweck danielweck mentioned this issue Apr 14, 2015
Open
@danielweck
Copy link
Member Author

I forgot to mention, the above fix is committed to a "feature" branch: https://github.com/readium/readium-shared-js/compare/feature/177-scalerDivZoomedSize

@danielweck
Copy link
Member Author

Follow-up: also test scroll view! See readium/readium-js-viewer#313 (comment)

danielweck added a commit that referenced this issue May 13, 2015
@danielweck
Merge pull request #183 from readium/feature/177-scalerDivZoomedSize
141fea5 
fix for #177 scaler div zoomed dimensions with needsFixedLayoutScalerWorkAround
@danielweck danielweck mentioned this issue May 13, 2015
Merged
@danielweck
Copy link
Member Author

Fixed by Pull Request: #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielweck danielweck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck