- fixed fullscreen command / button not up to date #48 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larsvoigt thanks for the contribution. This issue was assigned to someone. Therefore, it was being actively worked on. Daniel, (the assignee) is on vacation, so I was working on this issue. I wasn't aware that the icon was broken in Firefox. I incorporated a fix into my solution. I just committed my fix to the develop branch |
|
Okay!? @ryanackley You forget to toggle the title attribute. Have a look at my solution. |
|
@larsvoigt I have just discovered your comment above. I observed the same problem and logged an issue here: |
|
Thank you @danielweck. I have noticed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #48
that fixed also: fullscreen button will never updated if using firefox browser