Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landmarks and labels #93

Closed
becka11y opened this issue Jul 23, 2014 · 2 comments
Closed

Update landmarks and labels #93

becka11y opened this issue Jul 23, 2014 · 2 comments

Comments

@becka11y
Copy link
Contributor

The table of contents area is not labeled as a landmark. Adding this would allow screen reader users to move to the ToC using the landmark features of screen readers (list landmarks or navigate from landmark to landmark). I would suggest labeling the ToC with a role=navigation and an aria-label="Table of Contents" or add an id to the H2 that represents the Table of Contents text and use aria-labelledby. There is already a resource string for the "Table of Contents" text.

Since the keyboard shortcuts refer to the Toolbar it should be labeled as such. Right now the toolbar does have a role=navigation, I would add a label of "Toolbar". This would also need an added string resource for translation. Better yet would be to add the keyboard arrow key navigation and make it true toolbar with a role of toolbar. But, that is a stretch goal.

@danielweck
Copy link
Member

Fixed by:
70fd6fb

@danielweck
Copy link
Member

New issue recorded for arrow keys navigation of toolbar:

#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants