Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that fixed layout documents have no margins or padding #673

Closed
rkwright opened this issue Nov 16, 2017 · 2 comments
Closed

Ensure that fixed layout documents have no margins or padding #673

rkwright opened this issue Nov 16, 2017 · 2 comments

Comments

@rkwright
Copy link
Contributor

This issue is a Bug

Related issue(s) and/or pull request(s)

readium/readium-shared-js#423

Expected Behaviour

A fixed layout document should not be styled (except possibly for themes). No margins, padding or other styles should be injected into the document.

Observed behaviour

Currently, if the author of an EPUB does not specify a margin on the body element, the RS will add a margin of 8 pixels from the user-agent style sheet.

Steps to reproduce

  1. Load the test file (see below)
  2. Check page 4. Note that the red rectangle is cut off
  3. Check the margin in the browser's inspector.

Test file(s)

https://drive.google.com/open?id=10y7ZJKdoG2yDVfqXLRkCWrDcbRDhW_eq

Product

  • Readium Chrome extension (current)
  • Readium cloud reader app
  • SDKLauncher-OSX

Additional information

None

@danielweck
Copy link
Member

Pull Request: readium/readium-shared-js#424

@danielweck
Copy link
Member

Tested with the cloud reader and Ric's original Tiny-FXL.epub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants