zip libraries in both readium-js-viewer and readium-js, update all to latest version?

[danielweck]

readium-js lib folder listing (the zip utility is used by the cloud reader to read EPUBs directly from the packed archive):
https://github.com/readium/readium-js/tree/develop/lib

readium-js-viewer lib folder listing (the zip utility is used to decompress/unpack the EPUB archives into the Chrome file system):
https://github.com/readium/readium-js-viewer/tree/master/lib/thirdparty

Right now, the files zip.js, zip-ext.js, zip-fs.js, deflate.js, and inflate.js are out of date. Also, z-worker.js is missing.

I guess these files should be updated in both repositories, consistently.

Dowloadable library package:
http://gildas-lormeau.github.io/zip.js/

Source code tree:
https://github.com/gildas-lormeau/zip.js/tree/master/WebContent

[danielweck]

See Pull Requests (WIP, not tested yet):

#290
Feature branch:
https://github.com/readium/readium-js-viewer/commits/feature/zip-lib-update

readium/readium-js#92
Feature branch:
https://github.com/readium/readium-js/commits/feature/zip-lib-update

[danielweck]

Using the aforementioned Pull Requests, I successfully tested the cloud reader with zipped EPUBs (bearing in mind the known caveats of audio/video/subtitle playback fail, see readium/readium-js#93 and readium/readium-js#94 ).

[danielweck]

Note that @ryanackley implemented a fix that required modifying the zip library (BlobWriter), so we must preserve Ryan's changes in readium-js-viewer (I'm not sure about readium-js yet, as the EPUB loading strategy is different). See: 31e55f5#commitcomment-9873847
See:
#280

[danielweck]

I've just noticed that because z-worker.js is missing, the cloud reader cannot load unpacked ePUBs anymore (develop branch). This is reproducible with both with the "proper" grunt cloudReader build (Almond'ed RequireJS bundles), and the index.html simple dev runtime (no parameter grunt => live RequireJS). So, it looks like the zip lib from readium-js-viewer is used instead of the one from readium-js (the latter still has the old zip lib version which did not require z-worker.js). Arghh! I look forward to complete the feature/plugins work which includes improving the RequireJS build, so that such lib discrepancies will not occur anymore. Meanwhile, my feature/zip-lib-update branch (mentioned above) seems to be the answer. I just need to make sure to include @ryanackley 's patch to BlobWriter.

[danielweck]

readium-js-viewer fixed here: 68c1ac7

readium-js still needs fixing, but the file zip.js must preserve @ryanackley 's Blob patch, to be consistent. This is not urgent, as the cloud reader builds include JS libs from the lib/thirdparty folder in readium-js-viewer (not from readium-js's own lib folder, even though the cloud reader "unpacked EPUB" feature is actually implemented there). Actually, an even better course of action is to complete the RequireJS refactoring, so that we can get eliminate issues with duplicated libs / inconsistent versions!

[danielweck]

@ryanackley I have just successfully tested the big german EPUB that was making the Readium Chrome extension crash when importing it, it still works fine (I preserved your patch in zip.js, but updated the other files, see 68c1ac7 ).
The EPUB TestEpubThatCrashReadium.epub that was privately shared with us was from Niclas Bergstorm (ReadSpeaker). Could you please test the develop branch on your end with the EPUB that initially prompted you to implement the zip fix? Many thanks! Dan

[danielweck]

Note that this is addressed in the "plugins" feature branch(es) for both readium-js and readium-js-viewer (no more duplicate zip-js lib, and we use Ryan's patched version obtained via an NPM package hosted on GitHub)

[danielweck]

Fixed via RequireJS refactoring:
https://github.com/readium/readium-js/blob/develop/package.cson#L105

#    "zipjs": 'gildas-lormeau/zip.js'
#    "zipjs": 'ryanackley/zip.js'
    "zipjs": "danielweck/zip.js"

(we fork the zipjs lib to patch it, and we track upstream changes when invoking npm run prepare, just in case the author updates the original lib)