Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery Ajax fails in Windows because of implicit JSON return type (should be explicit, otherwise the returned payload is just a string) #284

Closed
danielweck opened this issue Feb 12, 2015 · 1 comment
Closed

jQuery Ajax fails in Windows because of implicit JSON return type (should be explicit, otherwise the returned payload is just a string) #284

danielweck opened this issue Feb 12, 2015 · 1 comment

Comments

@danielweck
Copy link
Member

https://github.com/readium/readium-js-viewer/blob/develop/lib/versioning/UnpackagedVersioning.js#L18

$.get('package.json', function(data){}

data is a string, not JSON, which crashes.
danielweck added a commit that referenced this issue Feb 12, 2015
@danielweck
Fixes #284
2e9ccc3 
jQuery Ajax fails in Windows because of non-explicit JSON return type
@danielweck
Copy link
Member Author

Fixed here: 2e9ccc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck