Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary scroll bar displayed in reflow view (pan-zoom viewport overflow:auto?) #232

Closed
Kathybluefire opened this issue Oct 23, 2014 · 2 comments

Comments

@Kathybluefire
Copy link

If you watch this flow, you'll see a couple areas of concern. Maybe by design, and if so, then there is no issue, but wanted to bring up to be sure.

  1. Open Reflowable Doc with the browser full screen and you see the default -- spreads
    readium8
  2. Drag the browser horizontally until the aspect ration is taller than wide, and the content goes to single pages. Expected.
    readium9
  3. Open the Table of Contents and you get a superfluous scroll bar on the right. Why?
    readium10
  4. Set the User Setting to Spreads and we lose the aspect ratio rule and can have long thin pages by scaling the browser horizontally. One would think the single page in proportion to the content window would hold up, even if the user selects spreads. Is there a technical reason why it doesn't?

readium11

@danielweck
Copy link
Member

User preferences take precedence, even if the forced two-page spread results in narrow columns of text. So that's okay.

However the scroll bar is problematic, and was reported before (although I could not reproduce this myself). I think the culprit is the pan-zoom feature for fixed layout documents, which allows overflow:auto on the viewport (for panning). This needs to be fixed.

@danielweck danielweck changed the title Chrome Extension Windows 7: Default flow with change in user setting provides inconsistent UX unnecessary scroll bar displayed in reflow view (pan-zoom viewport overflow:auto?) Oct 23, 2014
danielweck added a commit to readium/readium-shared-js that referenced this issue Oct 23, 2014
… or scroll views. Fixes readium/readium-js-viewer#232

(fixes Chrome extension/cloud reader, as well as native apps (although they do not expose "zoom" UI affordances yet))
(trivial tested fix, no need for feature branch + pull request)
@danielweck
Copy link
Member

Scroll bar fixed here:
readium/readium-shared-js@6b89df6

johanpoirier pushed a commit to TEA-ebook/readium-shared-js that referenced this issue Nov 13, 2014
… or scroll views. Fixes readium/readium-js-viewer#232

(fixes Chrome extension/cloud reader, as well as native apps (although they do not expose "zoom" UI affordances yet))
(trivial tested fix, no need for feature branch + pull request)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants