Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font and margin sliders in options dialog not set to correct offset at first run #112

Closed
danielweck opened this issue Jul 29, 2014 · 1 comment
Closed

Font and margin sliders in options dialog not set to correct offset at first run #112

danielweck opened this issue Jul 29, 2014 · 1 comment

Comments

@danielweck
Copy link
Member

(first run = when no font/margin user settings have been saved to browser storage yet)

This results in the wrong font size when pressing the "save" button, because the slider is in the middle (instead of one step back, which is 100%).
The margins slider wrong initialisation does not have any negative effects because the middle initial position is correct.
danielweck added a commit that referenced this issue Jul 29, 2014
@danielweck
fixes #113 and #112 (margin + font slider options)
876d13c
@danielweck
Copy link
Member Author

Fixed:
876d13c

@davedmiller davedmiller mentioned this issue Aug 18, 2015
Open
larsvoigt pushed a commit to larsvoigt/readium-js-viewer that referenced this issue Oct 9, 2015
- fixed readium#112
cfbfb18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck