Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFI-based bookmarks can only target text elements #1

Closed
rkwright opened this issue Mar 26, 2013 · 2 comments
Closed

CFI-based bookmarks can only target text elements #1

rkwright opened this issue Mar 26, 2013 · 2 comments

Comments

@rkwright
Copy link
Contributor

Summary
The current implementation of the bookmarks functionality using the core CFI implementation can only target text elements, not images, objects or other valid content elements.

Details

  1. Open an EPUB consisting only of images (e.g. Manga) or a page that only contains an image.
  2. Try to bookmark a page.
  3. The bookmarking fails

Files
Alice3.epub - use one of the pages with a large image (e.g. the cover)

@rkwright
Copy link
Contributor Author

I think there two possible problems.

One, is that you have not included the Readium Core library itself. Try
dragging that Xcode project file into the LauncherOSX project
Two ¡V more likely ¡V you opened the SDKLauncherOSX xcodeproject rather than
the Workspace, I.e.

LauncherOSX.xcworkspace

Let us know if that helps.

Ric

From: AnFengDe [email protected]
Reply-To: readium/SDKLauncher-OSX
<reply+i-12460095-b5228ea60273307b949109fa3f489420306d8b98-3025864@reply.git
hub.com>
Date: Monday, April 22, 2013 1:37 AM
To: readium/SDKLauncher-OSX [email protected]
Cc: Ric Wright [email protected]
Subject: Re: [SDKLauncher-OSX] CFI-based bookmarks can only target text
elements (#1)

I can not compile it, the spine.h and container.h missing.
Uploading Screen Shot 2013-04-22 at ¤U¤È2.35.37.png . . .
Uploading Screen Shot 2013-04-22 at ¤U¤È2.36.00.png . . .

¡X
Reply to this email directly or view it on GitHub
#1 (comment)
.

@AnFengDe
Copy link

Thanks a lot, I have not included readium-sdk library project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants