-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when activities on, browse button is not visible in mobile view fixed #1028
Conversation
@yeshwantthota is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
@@ -67,6 +67,18 @@ const HeaderNav = ({ showBrowse }) => { | |||
<span className="sr-only">Close</span> | |||
</button> | |||
</li> | |||
{showToggleMenu && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yeshwantthota We should have the activities on condition also, right? Otherwise the toggle bar browse is going to appear in the default mode also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the activities condition should be on. so should I "on" the activities and then create another PR?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions! |
Description
Browse button is not visible in the mobile view when activities are on, so in this commit I have fixed that bug.
Fixes # (issue)
#1019
Type of change
Please delete options that are not relevant.
Checklist:
I have performed a self-review of my own code
My changes generate no new warnings
Screenshots or example output