Bump Gradle to 7.2 #170
Merged
Bump Gradle to 7.2 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #169
simonbasle
suggested changes
Oct 28, 2021
gradle/asciidoc.gradle
Outdated
| resources { | ||
| from(sourceDir) { | ||
| include 'images/**' | ||
| include 'highlight/**/*' |
There was a problem hiding this comment.
don't think you have/need this since source highlighter is coderay
src/docs/asciidoc/index.asciidoc
Outdated
| @@ -1,6 +1,6 @@ | |||
| = Reactor RabbitMQ Reference Guide | |||
| Arnaud Cogoluègnes, Pawel Mackowski | |||
| // version is automatically set in doc.gradle, no need to change it here | |||
| // version is automatically set in asciidoc.gradle, no need to change it here | |||
| :appversion: 1.0.0.BUILD-SNAPSHOT | |||
There was a problem hiding this comment.
this is set in the configuration, so it can probably removed from here, just in case?
build.gradle
Outdated
| @@ -70,7 +68,7 @@ configure(allprojects) { project -> | |||
| maven { url 'https://repo.spring.io/snapshot' } | |||
| } | |||
|
|
|||
| apply plugin: 'maven' | |||
| apply plugin: 'maven-publish' | |||
There was a problem hiding this comment.
this actually can be removed entirely, as maven-publish is applied in setup.gradle
After @simonbasle's remarks. References #169
Because import org.gradle.util.VersionNumber is deprecated, will be removed in Gradle 8.0, and Gradle does not replacement. References #169
simonbasle
approved these changes
Oct 28, 2021
References #169
simonbasle
approved these changes
Oct 28, 2021
acogoluegnes
added a commit
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169