Use new gha API for setting output, latest core actions #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the way job output is defined, using the new way of a GITHUB_OUTPUT file environment variable. The old way of echoing strings is deprecated for sensitive elements, including action/job output. It also reorders the output in order to: • ensure BAD version is detected before any output and fails the job • ensure only one version/versionType is outputted when there are multiple modules (here, the `reactor-pool` one) See also reactor/reactor-core#3237.
simonbasle
added
the
type/chore
GitHub core actions updated to v3 to also remove NodeJs deprecation warnings: - checkout to v3.1.0 - setup-java to v3.6.0 Also upgrade gradle/gradle-build-action to v2.3.3, which should remove all the warnings about deprecated APIs.
chemicL
approved these changes
Oct 25, 2022
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
Oct 25, 2022
(fixing conflicts in the way only main module is taken into account)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way job output is defined, using the new way of
a GITHUB_OUTPUT file environment variable.
The old way of echoing strings is deprecated for sensitive elements,
including action/job output.
It also reorders the output in order to:
• ensure BAD version is detected before any output and fails the job
• ensure only one version/versionType is outputted when there are
multiple modules (here, the
reactor-poolone)Finally it updates core and gradle actions to latest versions.
This fixes warnings about deprecated output style and deprecated Node
version being still in use by these actions.
See reactor/reactor#727.