Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #581 Add ConnectionProvider#disposeAllLater which closes active and inactive connections #584

Closed
wants to merge 1 commit into from

Conversation

violetagg
Copy link
Member

For active connections, this will shutdown the EventExecutorGroup,
the default quietPeriod and timeout will be used as
specified by EventExecutorGroup#shutdownGracefully()

…nd inactive connections

For active connections, this will shutdown the EventExecutorGroup,
the default quietPeriod and timeout will be used as
specified by EventExecutorGroup#shutdownGracefully()
@violetagg violetagg added this to the 0.8.5.RELEASE milestone Jan 22, 2019
@violetagg violetagg requested a review from smaldini January 22, 2019 16:09
@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #584 into master will increase coverage by 0.22%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #584      +/-   ##
============================================
+ Coverage     64.29%   64.52%   +0.22%     
- Complexity     1332     1343      +11     
============================================
  Files           126      126              
  Lines          6361     6379      +18     
  Branches        849      852       +3     
============================================
+ Hits           4090     4116      +26     
+ Misses         1818     1810       -8     
  Partials        453      453
Impacted Files Coverage Δ Complexity Δ
...va/reactor/netty/resources/ConnectionProvider.java 50% <0%> (-2.39%) 7 <0> (ø)
...ctor/netty/resources/PooledConnectionProvider.java 78.77% <88.23%> (+0.61%) 23 <3> (+3) ⬆️
...eactor/netty/channel/ChannelOperationsHandler.java 70.26% <0%> (-0.89%) 64% <0%> (+2%)
...a/reactor/netty/http/client/HttpClientConnect.java 54% <0%> (+0.29%) 4% <0%> (ø) ⬇️
...java/reactor/netty/http/server/HttpServerBind.java 38.36% <0%> (+0.43%) 21% <0%> (+1%) ⬆️
...eactor/netty/http/server/HttpServerOperations.java 70.85% <0%> (+0.44%) 61% <0%> (ø) ⬇️
...eactor/netty/http/client/HttpClientOperations.java 54.04% <0%> (+0.86%) 66% <0%> (+1%) ⬆️
src/main/java/reactor/netty/tcp/TcpServer.java 51.38% <0%> (+2.77%) 23% <0%> (+2%) ⬆️
...rc/main/java/reactor/netty/tcp/TcpServerRunOn.java 92.85% <0%> (+50%) 4% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b17d8c...67c2c11. Read the comment docs.

Copy link
Contributor

@smaldini smaldini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we close an event loop group shared by another component (server or client).

@violetagg
Copy link
Member Author

Closing this in favour of the fix for #586 in particular channelGroup

@violetagg violetagg closed this Jan 28, 2019
@violetagg violetagg deleted the issue-581 branch January 28, 2019 15:32
@violetagg violetagg removed this from the 0.8.5.RELEASE milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants