fix #495 Ensure all children channels are closed when invoking DisposableServer#dispose

[violetagg]

No description provided.

[codecov-io]

Codecov Report

Merging #497 into master will decrease coverage by 0.25%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master     #497      +/-   ##
============================================
- Coverage     63.91%   63.65%   -0.26%     
+ Complexity     1332     1308      -24     
============================================
  Files           126      125       -1     
  Lines          6354     6271      -83     
  Branches        846      836      -10     
============================================
- Hits           4061     3992      -69     
- Misses         1841     1842       +1     
+ Partials        452      437      -15

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/reactor/netty/http/server/HttpServer.java	68.05% <ø> (ø)	30 <0> (ø)	⬇️
src/main/java/reactor/netty/tcp/TcpServer.java	51.38% <ø> (+2.77%)	23 <0> (+2)	⬆️
src/main/java/reactor/netty/tcp/TcpServerBind.java	87.23% <100%> (+0.27%)	11 <0> (ø)	⬇️
...java/reactor/netty/http/server/HttpServerBind.java	37.76% <85.71%> (-0.17%)	21 <9> (+1)
src/main/java/reactor/netty/tcp/ProxyProvider.java	47.22% <0%> (-17.83%)	14% <0%> (-7%)
...ctor/netty/resources/PooledConnectionProvider.java	72.51% <0%> (-5.65%)	14% <0%> (-6%)
.../reactor/netty/http/client/WebsocketFinalizer.java	70% <0%> (-2.73%)	5% <0%> (-1%)
...reactor/netty/http/client/HttpClientFinalizer.java	79.48% <0%> (-2.57%)	20% <0%> (ø)
...r/netty/http/server/WebsocketServerOperations.java	62.12% <0%> (-2.52%)	16% <0%> (-3%)
src/main/java/reactor/netty/ByteBufMono.java	36.58% <0%> (-2.44%)	7% <0%> (-1%)
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db96bed...8bda36d. Read the comment docs.

[smaldini]

The following feels a bit hacky and prone to errors for multiple subscribe (even if that is niche case, its still a possibility for the user).

s -> {  disposableBind.server = s; 
//... 
}```

I wonder if we just need to document this or add a separate explicit option to the server creation like `cleanEventLoopsOnDispose(boolean)` with the documentation referring to the shutdown of underlying channels.

[violetagg]

Closing this in favour of the fix for #586 in particular channelGroup