Ensure DisposedChannelConfig#setAutoRead does not change auto-read configuration
#3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration DisposedChannel is effective when request/response is terminated and replaces the actual channel. At that point DisposedChannelConfig#setAutoRead must be non operational as the inbound has already been read and the actual channel has already set auto-read to true. The issue is also observed with the reproducible example provided by #3495 Fixes #3559
violetagg
added
type/bug
violetagg
added a commit
that referenced
this pull request
Jan 6, 2025
violetagg
added a commit
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisposedChannelis effective when request/response is terminated and replaces the actual channel. At that pointDisposedChannelConfig#setAutoReadmust be non operational as the inbound has already been read and the actual channel has already set auto-read to true.The issue is also observed with the reproducible example provided by #3495
Fixes #3559