HttpServerRequest::receiveContent() never emits any value nor completes when HTTP/1.1 TLS Upgrade (RFC-2817) kicks in #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when HTTP/1.1 TLS Upgrade (RFC-2817) kicks in Signed-off-by: Andriy Redko <[email protected]>
reta
commented
Dec 10, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java
Outdated
Show resolved
Hide resolved
violetagg
reviewed
Dec 11, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
…ax content length) Signed-off-by: Andriy Redko <[email protected]>
violetagg
requested changes
Dec 16, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
violetagg
requested changes
Dec 16, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
violetagg
pushed a commit
that referenced
this pull request
Dec 17, 2024
…es when HTTP/1.1 TLS Upgrade (RFC-2817) kicks in (#3540) Signed-off-by: Andriy Redko <[email protected]>
violetagg
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have run into the issue with latest Apache HttpClient5 5.4.1 / Apache HttpCore5 5.3.1 as a client (Reactor Netty as the HTTP server with HTTP/1.1 and H2C protocols) that now tries HTTP/1.1 TLS Upgrade (RFC-2817) by default, see please [1] for context. The HttpServerRequest::receiveContent() never emits any value nor completes since no next / completion callbacks are called.
Closes #3538