Add timeout for DefaultLoopResources#disposeLater
#3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemicL
requested changes
Nov 18, 2024
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java
Outdated
Show resolved
Hide resolved
When shutting down EventLoopGroup, Netty tries to add for an execution a task that will stop the EventLoops. However if there is a CPU intensive task running on an EventLoop, the execution of the shutting down task might never happen. This change adds a timeout for DefaultLoopResources#disposeLater so that the user will be notified that some EventLoops cannot be stopped. Note: Having blocking and CPU intensive tasks on EventLoops is strongly discouraged and can lead to unpredictable failures. Fixes #3509
violetagg
force-pushed
the
issue-3509
branch
from
25b5265 to
dde2884
Compare
chemicL
approved these changes
Nov 19, 2024
|
@chemicL Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Nov 19, 2024
violetagg
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down
EventLoopGroup,Nettytries to add for an execution a task that will stopEventLoops. However if there is a CPU intensive task running onEventLoop, the execution of the shutting down task might never happen.This change adds a timeout for
DefaultLoopResources#disposeLaterso that the user will be notified that someEventLoopscannot be stopped.Note: Having blocking and CPU intensive tasks on
EventLoopsis strongly discouraged and can lead to unpredictable failures.Fixes #3509