Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate zstd compression #3126

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Validate zstd compression #3126

merged 1 commit into from
Apr 2, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Apr 1, 2024

Netty supports zstd compression.

This PR validates that zstd compression is working as expected.

https://github.com/luben/zstd-jni

violetagg
violetagg approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sullis Thanks for the PR!

@violetagg violetagg added the type/test A general test label Apr 1, 2024
@violetagg violetagg added this to the 1.2.0-M1 milestone Apr 1, 2024
@violetagg violetagg requested a review from a team April 1, 2024 14:40
@violetagg
Copy link
Member

@reactor/netty-team PTAL

pderop
pderop approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sullis thank you!

@violetagg violetagg merged commit 2d85255 into reactor:main Apr 2, 2024
14 checks passed
@violetagg violetagg changed the title validate zstd compression Validate zstd compression Apr 2, 2024
pderop added a commit that referenced this pull request Apr 2, 2024
@pderop
Merge #3120 and #3126 into 2.0.0-M4
0ae797c
@sullis sullis deleted the validate-zstd-server-compression branch April 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

@violetagg violetagg violetagg approved these changes

Assignees
No one assigned
Labels
type/test A general test
Projects
None yet
Milestone
1.2.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@sullis @violetagg @pderop