When metrics are enabled and responseTimeout is configured, ensure the correct order for ChannelHandlers
#3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e correct order for ChannelHandlers - Place ResponseTimeoutHandler before HttpMetricsHandler so that is an error happened it can be recorded - Add test to verify that errors with establishing a connection are recorded Fixes #3060
pderop
approved these changes
Mar 8, 2024
violetagg
changed the title
responseTimeout is configured, ensure the correct order for ChannelHandlers
|
@pderop Thanks! |
violetagg
added a commit
that referenced
this pull request
Mar 11, 2024
violetagg
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseTimeoutHandlerbeforeHttpMetricsHandlerso that is an error happened it can be recordedFixes #3060