-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a http snoop server
sample
#2883
Add a http snoop server
sample
#2883
Conversation
@longkunbetter Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@longkunbetter Thank you for signing the Contributor License Agreement! |
…and tells the client the details of the request in a formatted string #{761}
245e610
to
c2f9ca0
Compare
@longkunbetter Thanks for the PR. Can you use the same pattern as below link (for system properties etc.) |
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopServer.java
Outdated
Show resolved
Hide resolved
@violetagg Thanks for your feedback. |
@violetagg |
http snoop server
sample
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopServer.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopServer.java
Outdated
Show resolved
Hide resolved
…tp/snoop/HttpSnoopClient.java Co-authored-by: Violeta Georgieva <[email protected]>
…tp/snoop/HttpSnoopClient.java Co-authored-by: Violeta Georgieva <[email protected]>
…tp/snoop/HttpSnoopClient.java Co-authored-by: Violeta Georgieva <[email protected]>
…tp/snoop/HttpSnoopServer.java Co-authored-by: Violeta Georgieva <[email protected]>
…tp/snoop/HttpSnoopServer.java Co-authored-by: Violeta Georgieva <[email protected]>
@longkunbetter Can you fix the import
|
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopServer.java
Outdated
Show resolved
Hide resolved
…tp/snoop/HttpSnoopClient.java Co-authored-by: Pierre De Rop <[email protected]>
…tp/snoop/HttpSnoopServer.java Co-authored-by: Pierre De Rop <[email protected]>
I have fixed it. Should I squash my commits? |
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopServer.java
Outdated
Show resolved
Hide resolved
reactor-netty-examples/src/main/java/reactor/netty/examples/http/snoop/HttpSnoopServer.java
Outdated
Show resolved
Hide resolved
No need I can squash them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests failure on CI with Mac OS is not relevant to this PR
@longkunbetter Thanks again for the PR! |
No thanks, I'm glad to contribute to this project. |
Add a 'http snoop server' sample which receives any request and tells the client the details of the request in a formatted string #{761}
This is a sample http server that corresponds to HttpSnoopServer in examples of project netty.
Please notice that the http snoop server is not the same as the http echo server.
It will return the details of the request, not only the request body.
So I think it is a good example for people who want to learn how to use reactor-netty to build a http server and have a full control of the request and response.
I have tested it and it works well.
I'm unfamilar with such PR operation, if there is any problem please tell me.