Add system properties for enabling SamplingAllocationStrategy #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"reactor.netty.pool.getPermitsSamplingRate" and "reactor.netty.pool.returnPermitsSamplingRate" are exposed in order to be able to enable Reactor Pool's SamplingAllocationStrategy
simonbasle
reviewed
Jan 7, 2021
| DEFAULT_POOL_GET_PERMITS_SAMPLING_RATE, | ||
| DEFAULT_POOL_RETURN_PERMITS_SAMPLING_RATE)); | ||
| } | ||
| else { |
There was a problem hiding this comment.
I would consider at least logging a warning if (some) of the values are set but out of 0-1 bounds (eg. somebody sets sampling rate at 50 thinking it's 50 percent). Negative can probably be silently ignored, and 0 (defaults) totally can be silently ignored, but positives above 1.0 should definitely trigger some warning. That said, maybe that check should be done in a static final initializer block upon loading the system property ?
simonbasle
reviewed
Jan 7, 2021
simonbasle
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reactor.netty.pool.getPermitsSamplingRateandreactor.netty.pool.returnPermitsSamplingRateare exposedin order to be able to enable Reactor Pool's
SamplingAllocationStrategy