Propagate ThreadLocals for non-Reactor upstream sources #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory methods for creating `Flux` and `Mono` from non-Reactor sources now restore `ThreadLocal` values when `Hooks.enableAutomaticContextPropagation()` was called in the following cases: * Flux.from(Publisher) * Mono.from(Publisher) * Mono.fromDirect(Publisher) * Mono.fromFuture(CompletableFuture) * Mono.fromCompletionStage(CompletionStage) and relevant overrides. Fixes #3366.
chemicL
added
type/enhancement
chemicL
commented
Mar 28, 2023
Comment on lines
-65
to
-66
| Fuseable, | ||
| QueueSubscription<T>, |
There was a problem hiding this comment.
Note, MonoCompletionStage also has Fuseable removed. They are not needed, as the fusion support is NONE. And it makes the subscriber wrapping to the restoring subscriber possible (it is not Fuseable).
|
Verified against the reproducer provided in spring-projects/spring-boot#34374 - trace info is present with this branch. |
OlegDokuka
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory methods for creating
FluxandMonofrom non-Reactor sources now restoreThreadLocalvalues whenHooks.enableAutomaticContextPropagation()was called in the following cases:Flux.from(Publisher)Mono.from(Publisher)Mono.fromDirect(Publisher)Mono.fromFuture(CompletableFuture)Mono.fromCompletionStage(CompletionStage)and relevant overloads.
Fixes #3366.