Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflection hints for native-image support #3325

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

violetagg
Copy link
Member

native-image support is needed only for 3.5.x version

Fixes #3321

@violetagg violetagg added the type/bug A general bug label Jan 4, 2023
@violetagg violetagg added this to the 3.5.2 milestone Jan 4, 2023
@violetagg violetagg requested a review from a team as a code owner January 4, 2023 12:16
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @violetagg for adding the hints! Is there any way to have a self-contained validation within the reactor-core project for this or is spring smoke test (https://github.com/spring-projects/spring-aot-smoke-tests) the go-to validation mechanism? Do you think adding the reference to that repository somewhere in the documentation would be beneficial?

@violetagg
Copy link
Member Author

violetagg commented Jan 4, 2023

Thanks @violetagg for adding the hints! Is there any way to have a self-contained validation within the reactor-core project for this or is spring smoke test (https://github.com/spring-projects/spring-aot-smoke-tests) the go-to validation mechanism? Do you think adding the reference to that repository somewhere in the documentation would be beneficial?

It would be better Reactor Core to provide tests

As examples one can use
https://github.com/spring-projects/spring-aot-smoke-tests
https://github.com/oracle/graalvm-reachability-metadata

@chemicL
Copy link
Member

chemicL commented Jan 4, 2023

I created an issue (#3326) to the backlog so we can add the tests but not block rolling out the hints in the next release.

@violetagg violetagg merged commit 9d47a04 into main Jan 4, 2023
@violetagg violetagg deleted the native-image-configuration branch January 4, 2023 15:10
@violetagg
Copy link
Member Author

@chemicL @OlegDokuka Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please add GraalVM reflection hints files for the three subclasses under Traces
3 participants