Rework Processor-with-upstream case to be backward compatible #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reworks #3042 and reverts the changes to RootSpec returning methods. These changes were binary incompatible with the previous release of reactor, despite an API-compatible change. What is reverted: - the `UnsafeRootSpec` and intermediate specs are removed - `Sinks.unsafe()` is back to returning `RootSpec` What is kept: - `RootSpec` is dedicated to `Sinks.unsafe()` - `Sinks.manyWithUpstream` interface is still introduced What is modified: - `RootSpec` receives an additional `manyWithUpstream()` method which is the one exposing `Sinks.manyWithUpstream` implementations
OlegDokuka
approved these changes
Jun 7, 2022
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks #3042 and reverts the changes to RootSpec returning
methods. These changes were binary incompatible with the previous
release of reactor, despite an API-compatible change.
What is reverted:
UnsafeRootSpecand intermediate specs are removedSinks.unsafe()is back to returningRootSpecWhat is kept:
RootSpecis dedicated toSinks.unsafe()Sinks.manyWithUpstreaminterface is still introducedWhat is modified:
RootSpecreceives an additionalmanyWithUpstream()method whichis the one exposing
Sinks.manyWithUpstreamimplementations