Fix a Many sink / EmitterProcessor subscriber disposal leak #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EmitterProcessor#remove method causes retaining of subscribers if the removal is done in parallel, as the CAS failure doesn't cause a new loop iteration. This applies to direct instantiations of EmitterProcessor as well as Sinks.many().onBackpressureBuffer sinks. This commit fixes the method to loop back when the CAS fails. Fixes #3028.
OlegDokuka
approved these changes
Apr 21, 2022
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EmitterProcessor#remove method causes retaining of subscribers if
the removal is done in parallel, as the CAS failure doesn't cause a
new loop iteration.
This applies to direct instantiations of EmitterProcessor as well as
Sinks.many().onBackpressureBuffer sinks.
This commit fixes the method to loop back when the CAS fails.
Fixes #3028.