Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate FluxSink, MonoSink and SynchronousSink currentContext() method, add getContextView() one #2971

Closed
simonbasle opened this issue Mar 17, 2022 · 1 comment
Closed

Deprecate FluxSink, MonoSink and SynchronousSink currentContext() method, add getContextView() one #2971

simonbasle opened this issue Mar 17, 2022 · 1 comment
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Milestone
3.4.17

Comments

@simonbasle
Copy link
Member

It seems these three classes were overlooked when ContextView was introduced and the Context-returning methods were deprecated.

These three classes should get a ContextView getContextView() method, similar to what's been added to eg. Signal.
In addition, their currentContext() method should be deprecated for removal in 3.6.0 at the earliest.

The deprecation can occur either in 3.4.17+ or alternatively directly in 3.5.0.
@simonbasle simonbasle added type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations labels Mar 17, 2022
@simonbasle simonbasle modified the milestones: 3.4.x Backlog, 3.4.17 Mar 17, 2022
@simonbasle
Copy link
Member Author

Note: this should also make it to 3.5.0-M1

@simonbasle simonbasle mentioned this issue Mar 17, 2022
Merged
simonbasle added a commit that referenced this issue Mar 17, 2022
@simonbasle
Deprecate [Flux|Mono|Synchronous]Sink currentContext
aa15967 
This commit deprecates currentContext method in FluxSink, MonoSink and
SynchronousSink in favor of the newly introduced getContextView.

The methods are slated for removal in 3.6.0 at the earliest. These were
overlooked in the 3.4.0 release where other Context-returning methods
were deprecated.

Fixes #2971.
simonbasle added a commit that referenced this issue Mar 18, 2022
@simonbasle
Deprecate [Flux|Mono|Synchronous]Sink currentContext
e352fc8 
This commit deprecates currentContext method in FluxSink, MonoSink and
SynchronousSink in favor of the newly introduced getContextView.

The methods are slated for removal in 3.6.0 at the earliest. These were
overlooked in the 3.4.0 release where other Context-returning methods
were deprecated.

Fixes #2971.
@simonbasle simonbasle mentioned this issue Apr 20, 2022
Merged
simonbasle added a commit that referenced this issue Apr 20, 2022
@simonbasle
Backport: contextView() implem of [Flux|Mono|Synchronous]Sink
ffc5886 
This commit backports #3021, a default implementation of the
`contextView()` method of the FluxSink, MonoSink and SynchronousSink
"old sinks" classes.

The backport is necessary because the new method was not added only in
3.5.0-M1 as initially stated, but in 3.4.17 as well.

Backport of commit 6eecf85.
See #2971, #2974 and #3021.
simonbasle added a commit that referenced this issue Apr 20, 2022
@simonbasle
Backport: contextView() implem of [Flux|Mono|Synchronous]Sink (#3026)
1be0d59 
This commit backports #3021, a default implementation of the
`contextView()` method of the FluxSink, MonoSink and SynchronousSink
"old sinks" classes.

The backport is necessary because the new method was not added only in
3.5.0-M1 as initially stated, but in 3.4.17 as well.

Backport of commit 6eecf85.
See #2971, #2974 and #3021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Projects
None yet
Milestone
3.4.17
Development

No branches or pull requests
1 participant
@simonbasle