Fix Node.js version update at package.json
#6855
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
package.json
Outdated
| @@ -98,7 +98,7 @@ | |||
| "webpack-bundle-analyzer": "^4.5.0" | |||
| }, | |||
| "engines": { | |||
| "node": "^16.8.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0" | |||
| "node": "^16.8.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0 || ^22.0.0" | |||
There was a problem hiding this comment.
at this point we should actually not tag any versions but rather have node to be >=16.8.0 is what I feel? @rickhanlonii
There was a problem hiding this comment.
I can update it like this if you want.
There was a problem hiding this comment.
We might also want to verify if everything is working fine before we add these node versions. Like the start scripts. Seems like 17 alone is missing in between. If its verified we are GTG.
There was a problem hiding this comment.
Yes please, I loath node version checks - let's verify the oldest supported version and let's just be >= to that version, likely the same version Next requires. In the future, if a newer node version is broken, we can try to change the APIs so we support the newer version.
Fix Node.js version update at
package.json#6854