Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: "Configuring TypeScript" link for Next.js App Directory - to updated docs #6669

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

tomihq
Copy link
Contributor

@tomihq tomihq commented Feb 28, 2024

The old link redirects to the "Configuring TypeScript" with pages directory.

The Next.js team recommends using the 'App' directory now.

The old link redirects to the "Configuring TypeScript" with pages directory.

The Next.js team now recommends using the 'App' directory now.
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 28, 2024 6:15pm

@facebook-github-bot
Copy link
Collaborator

Hi @tomihq!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@tomihq tomihq changed the title update: "Configuring TypeScript" link for App Directory - Next.js docs update: "Configuring TypeScript" link for Next.js App Directory - to updated docs Feb 28, 2024
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Once the CLA is signed, I can merge this. May take a while between CLA signing and the bot to update the status

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@eps1lon eps1lon merged commit 6e650f9 into reactjs:main Feb 29, 2024
4 checks passed
@tomihq tomihq deleted the patch-1 branch February 29, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants