Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #6619

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix broken link #6619

merged 1 commit into from
Feb 11, 2024

Conversation

lakshmi930
Copy link
Contributor

Fixes: #6618

Screen recording:

Current:

Current.mov

Expected:

Expected.mov

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 7, 2024 8:48pm

Copy link

github-actions bot commented Feb 7, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.86 KB (🟡 +46 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.75 KB (🟡 +2 B) 183.61 KB
/500 79.75 KB (🟡 +2 B) 183.6 KB
/[[...markdownPath]] 81.44 KB (🟡 +2 B) 185.3 KB
/errors 79.93 KB (🟡 +2 B) 183.79 KB
/errors/[errorCode] 79.91 KB (🟡 +2 B) 183.76 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@rickhanlonii
Copy link
Member

Thanks for the fix, and for the detailed description, that made it easier to review!

@rickhanlonii rickhanlonii merged commit 4ff80a5 into reactjs:main Feb 11, 2024
4 checks passed
@lakshmi930 lakshmi930 deleted the fix-broken-link branch February 11, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link
3 participants