Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SandpackWithHTMLOutput to use src dir #6613

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

mattcarrollcode
Copy link
Contributor

@mattcarrollcode mattcarrollcode commented Feb 6, 2024

The SandpackWithHTMLOutput is broken, likely since #6496 this PR fixes the component by prefixing all files except package.json with src so the files are all in the place CodeSandbox expects. This broke 9 sandpacks across 5 pages. Fixes #6612

Preview links

<link> page

<meta> page

<script> page

<style> page

<title> page

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 6, 2024 5:02pm

Copy link

github-actions bot commented Feb 6, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mattcarrollcode mattcarrollcode marked this pull request as ready for review February 6, 2024 17:14
@mattcarrollcode mattcarrollcode merged commit c118938 into reactjs:main Feb 6, 2024
4 checks passed
@mattcarrollcode mattcarrollcode deleted the fix-sandbox branch February 6, 2024 17:36
@mattcarrollcode mattcarrollcode changed the title Fix Sandpack wiht HTML output to use src dir Fix SandpackWithHTMLOutput to use src dir Feb 6, 2024
trevlee0212 added a commit to trevlee0212/react.dev that referenced this pull request Feb 7, 2024
Fix SandpackWithHTMLOutput to use src dir (reactjs#6613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: all new sandboxes (with ShowRenderedHTML) break
3 participants