-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tailwind version #6550
Upgrade tailwind version #6550
Conversation
Add an ellipsis to overflowing text in the footer section for navigating between different references.
Fix overflowing text content in footer link
…nto upgrade-tailwind-version
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Hey Ricky, from our previous conversation (#6519 ), it was decided to upgrade the tailwindcss version to In |
tailwind.config.js
Outdated
@@ -60,9 +60,8 @@ module.exports = { | |||
...defaultTheme.maxWidth, | |||
xs: '21rem', | |||
}, | |||
minWidth:{ | |||
minWidth: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just remove this whole key since there are no overrides anymore.
@prajwalkulkarni not sure why it's 21 and not 20. You could either just leave it, or test every place it's used to see if 20 works just as well (i suspect it won't), or rename it to max-w-custom-xs, so max-w-xs is the default value. I don't have a strong opinion either way. |
The |
Awesome, thanks! In future PRs, please turn off the class sorting because it makes it difficult to review the changes. |
💫 Changelog
⭐ Upgrade
tailwindcss
to3.4.1
.⭐ Adds support for min-width
min-w-*
out of the box and more (https://tailwindcss.com/blog/tailwindcss-v3-4)⭐ Removed
80: '20rem'
fromminWidth
intailwind.config.js