Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New guides wanted #83

Open
10 tasks
bvaughn opened this issue Oct 8, 2017 · 33 comments
Open
10 tasks

New guides wanted #83

bvaughn opened this issue Oct 8, 2017 · 33 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Note this issue has some overlap with FAQ section issue #29.

We revamped the docs, but there are a few guides that are missing and that I think are essential.

Available

In progress

If somebody wants to work on this please comment here and let's figure out a plan. Help wanted!

Carry over from facebook/react/issues/8060

@markerikson
Copy link
Contributor

markerikson commented Oct 8, 2017

The ReactPerf item may sorta be OBE ("overtaken by events"), since it's not included in v16.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 8, 2017

Not sure what that acronym means but I assume you're suggesting we should remove it? 😄 I don't object.

@JasonEtco
Copy link

Not sure if you're already planning it, but I would add Didn't bind class methods to common troubleshooting issues 👍

@markerikson
Copy link
Contributor

@bvaughn : yeah, that's what I was suggesting :)

@JasonEtco : the "troubleshooting" suggestion overlaps heavily with the proposal for an FAQ page.

@AlmeroSteyn
Copy link
Collaborator

@bvaughn Accessibility has been added and can be checked off :-)

@mrscobbler
Copy link
Contributor

I'll take the glossary that I created in the old repo and migrate it to the new docs repo

@alexkrolick
Copy link
Collaborator

As @markerikson mentioned there is some overlap with the FAQ discussion (#29). PR #43 covers AJAX and some of the VDOM concepts although a full-fledged glossary would probably replace that section.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 9, 2017

Thanks @AlmeroSteyn. I've removed that entry.

Yeah, there's some overlap. I spent a few hours merging/moving issues and PRs yesterday but some of the larger/vaguer ones like this are a bit hard to do without a bit of overlap. I'll add a note in the description about the relationship.

@ishankbahl
Copy link
Contributor

Hey @bvaughn , I would like to work on "AJAX (just show how to use fetch() in lifecycles, mention cancellation issues)". Though now we don't have to talk about cancellation issues as fetch now supports abort https://developers.google.com/web/updates/2017/09/abortable-fetch
Can I take this one?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 10, 2017

It's all yours, @ishankbahl

@alexkrolick
Copy link
Collaborator

@ishankbahl @bvaughn AJAX is already in the FAQ PR #43, as I pointed out.

If that is too big of a PR to review I can break it up, but let's not duplicate effort.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 10, 2017

Sorry for missing that note, @alexkrolick. Thanks for pointing it out. Yeah, maybe hold off on doing anything with the AJAX section until after #43 has been reviewed @ishankbahl.

@mrscobbler
Copy link
Contributor

I just created a pull request for the glossary content: #153

@damaera
Copy link
Contributor

damaera commented Oct 16, 2017

while in vue docs there's something like this.
image

I think routing should have their own menu, because almost all SPA have router.
state management too.

@mateoholman
Copy link
Contributor

I'll take a stab at creating a guide for publishing a component if no one is currently working on it?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 20, 2017

Ok @mateoholman

@ishankbahl
Copy link
Contributor

@bvaughn Can I take snapshot testing?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 22, 2017

Sure @ishankbahl

@ishankbahl
Copy link
Contributor

@bvaughn What outline do you suggest for this guide?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 22, 2017

No clue 😄 Haven't thought about it any. Just migrated this issue from the old GitHub repo.

@mateoholman
Copy link
Contributor

Created a new PR for the "Publishing a Component" guide - #211.

@mateoholman
Copy link
Contributor

I'll try to tackle the community section per the recommendations in facebook/react#7117 next if no one is currently working on it?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 25, 2017

It's yours, @mateoholman

@mateoholman
Copy link
Contributor

After doing some prep/research, I see two approaches to the community section. Adding a new Resources section to the docs page similar to the React Native Docs or updating the React Wiki. Both have been suggested in previous issues - any preference @bvaughn ?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 31, 2017

👋 Hi @mateoholman. Sorry for the slow response time but I've been traveling.

I'm personally more a fan of the community page/section because it's more open for community contributions.

@mateoholman
Copy link
Contributor

👋 Hi @bvaughn . No worries, I had been scrubbing some of the outdated / broken links from the previous section. I should have a PR ready for review in a few days. 🍻

@mateoholman
Copy link
Contributor

@bvaughn Created a PR for the updated community section PR #252 . Mind if I take the "Animation with React Motion" guide next?

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 7, 2017

Sure @mateoholman. It's yours.

@chiangs
Copy link

chiangs commented Oct 2, 2019

@bvaughn I'd like to take the Troubleshooting Guide:

Besides the following you listed (like wrong element casing, not loaded DOM container, missing React in scope) any other items you suggest being covered?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 2, 2019

Okay @chiangs, please feel free to work on that! :)

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* First try

* Translated Thinking in React

* Delete package-lock.json

* Update content/docs/thinking-in-react.md

Review feedback

Co-Authored-By: rafaelquintanilha <[email protected]>

* Review feedback

* Review feedback

* Update content/docs/thinking-in-react.md

Co-Authored-By: rafaelquintanilha <[email protected]>
@alDuncanson
Copy link

It looks like portals have been taken care of right?

https://reactjs.org/docs/portals.html

@spiritanand
Copy link

Is this issue open? Can you assign it to me if it is?

@KenFoss
Copy link

KenFoss commented Dec 7, 2023

@bvaughn Is anyone taking animation with react motion? I would like to give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests