Bundle UMD with rollup #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TrySound
commented
Jan 14, 2019
•
TrySound
commented
```diff -Webpack production bundle is 18407b (no gzip) +Rollup production bundle is 14975b (no gzip) ```
|
Oops, it's 14975b. Didn't expected such behaviour from babel config. I don't like custom presets for this. They need to be learned. |
|
Guys, I already have esm support locally. Will push it after merging this PR. |
|
Hi @silvenon. Could you take a look at this? |
|
@silvenon Friendly ping |
|
Sorry for noise. Just want to get things done :) |
|
@silvenon Ping :) |
jquense
approved these changes
Feb 13, 2019
|
I think we can move this along, happy to any feedback in retro |
errendir
added a commit
to errendir/react-transition-group
that referenced
this pull request
Feb 14, 2019
…d-compatible * origin/master: chore: bundle UMD with rollup (reactjs#449) chore(release): 2.5.3 [skip ci] fix: strip custom prop-types in production (reactjs#448) chore: fix storybook (reactjs#445) chore(release): 2.5.2 [skip ci] fix: pass appear to CSSTransition callbacks (reactjs#441) docs: Fix type declaration comment (reactjs#439) chore(release): 2.5.1 [skip ci] fix: prevent calling setState in TransitionGroup if it has been unmounted (reactjs#435)
errendir
added a commit
to errendir/react-transition-group
that referenced
this pull request
Feb 14, 2019
…d-compatible * origin/master: chore: bundle UMD with rollup (reactjs#449) chore(release): 2.5.3 [skip ci] fix: strip custom prop-types in production (reactjs#448) chore: fix storybook (reactjs#445) chore(release): 2.5.2 [skip ci] fix: pass appear to CSSTransition callbacks (reactjs#441) docs: Fix type declaration comment (reactjs#439) chore(release): 2.5.1 [skip ci] fix: prevent calling setState in TransitionGroup if it has been unmounted (reactjs#435)
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.