Proposed fix for #29 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was hijacking the child ref onto the `CSSTransitionGroupChild`, this fix for reactjs#29 leaves the ref on child and lets the `TransitionGroup` add a ref to the wrapped child produced from `childFactory()`. (assumption: `childFactory()` always wraps the child) An improvement would to detect if the child was wrapped or not and chain appropriately.
jquense
requested changes
Apr 26, 2017
|
@jquense I added some tests, and went ahead and made the change to intelligently chain the refs or not if the childFactory creates a wrapper. |
jquense
approved these changes
May 2, 2017
|
🎉 |
This was referenced Sep 22, 2018
Merged
1 task
This was referenced Jan 7, 2019
1 task
marnusw
added a commit
to marnusw/react-css-transition-replace
that referenced
this pull request
Oct 11, 2019
It was called first with the child and a second time with the CSSTransitionGroupChild. The same issue was fixed in reactjs/react-transition-group#39. Since this library always creates a wrapper the solution is simpler: just don't chain the ref at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hijacking the child ref onto the
CSSTransitionGroupChild, this fix for #29 leaves the ref on child and lets theTransitionGroupadd a ref to the wrapped child produced fromchildFactory(). (assumption:childFactory()always wraps the child) An improvement would to detect if the child was wrapped or not and chain appropriately.