Fix Transition passes through all props to children in production build #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Jul 20, 2017
src/Transition.js
Outdated
| @@ -303,7 +438,7 @@ class Transition extends React.Component { | |||
| } | |||
|
|
|||
| const {children, ...childProps} = this.props; | |||
| Object.keys(Transition.propTypes).forEach(key => delete childProps[key]); | |||
| Object.keys(propTypes).forEach(key => delete childProps[key]); | |||
There was a problem hiding this comment.
lets do delete props.foo for each one manually instead, its a bit uglier but maintains the optimization
koba04
force-pushed
the
fix-removed-prop-types
branch
from
5b34d66 to
226213f
Compare
koba04
force-pushed
the
fix-removed-prop-types
branch
from
226213f to
0987135
Compare
|
@jquense Thanks! I've changed to delete the props manually and added a test for this. |
|
Thanks! |
This was referenced Sep 22, 2018
Merged
1 task
This was referenced Jan 7, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107