Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): fix key value + adding close tag for CSSTransition when needed #116

Merged
merged 1 commit into from
Jul 16, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class TodoList extends React.Component {

render() {
const items = this.state.items.map((item, i) => (
<div key={item} onClick={() => this.handleRemove(i)}>
<div key={i} onClick={() => this.handleRemove(i)}>
{item}
</div>
));
Expand All @@ -88,7 +88,7 @@ The most straightforward way to migrate is to use `<TransitionGroup>` instead of
```diff
render() {
const items = this.state.items.map((item, i) => (
<div key={item} onClick={() => this.handleRemove(i)}>
<div key={i} onClick={() => this.handleRemove(i)}>
{item}
</div>
));
Expand Down Expand Up @@ -141,14 +141,14 @@ Now we add the `<CSSTransition>` component:
render() {
const items = this.state.items.map((item, i) => (
+ <CSSTransition
+ key={item}
+ key={i}
+ classNames="example"
+ timeout={{ enter: 500, exit: 300 }}
+ >
<div onClick={() => this.handleRemove(i)}>
{item}
</div>
+ <CSSTransition>
+ </CSSTransition>
));

return (
Expand Down Expand Up @@ -184,15 +184,15 @@ We can then use it like:
render() {
const items = this.state.items.map((item, i) => (
- <CSSTransition
- key={item}
- key={i}
- classNames="example"
- timeout={{ enter: 500, exit: 300 }}
- >
+ <FadeTransition>
<div onClick={() => this.handleRemove(i)}>
{item}
</div>
- <CSSTransition>
- </CSSTransition>
+ </FadeTransition>
));

Expand Down